Skip to content

internal/ethapi: add timestamp to logs in eth_simulate #32831

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 4 commits into from
Oct 6, 2025
Merged

internal/ethapi: add timestamp to logs in eth_simulate #32831

merged 4 commits into from
Oct 6, 2025

Conversation

deffrian
Copy link
Contributor

@deffrian deffrian commented Oct 2, 2025 •
edited
Loading

Currently block timestamp in all eth_simulate logs is set to zero
This bug also migrated into hive tests

eth_simulateV1/ethSimulate-eth-send-should-produce-logs
eth_simulateV1/ethSimulate-eth-send-should-produce-more-logs-on-forward
eth_simulateV1/ethSimulate-logs
eth_simulateV1/ethSimulate-override-address-twice-in-separate-BlockStateCalls
eth_simulateV1/ethSimulate-self-destructive-contract-produces-logs
eth_simulateV1/ethSimulate-send-eth-and-delegate-call-to-eoa
eth_simulateV1/ethSimulate-send-eth-and-delegate-call-to-payble-contract
eth_simulateV1/ethSimulate-send-eth-and-delegate-call
eth_simulateV1/ethSimulate-simple-send-from-contract
eth_simulateV1/ethSimulate-use-as-many-features-as-possible

@deffrian deffrian mentioned this pull request Oct 3, 2025
Open
8 tasks
s1na
s1na previously approved these changes Oct 6, 2025
View reviewed changes
Copy link
Contributor

@s1na s1na left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM thanks

s1na
s1na approved these changes Oct 6, 2025
View reviewed changes
Copy link
Contributor

@s1na s1na left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fixed the tests so they check the timestamp too

@s1na s1na added this to the 1.16.5 milestone Oct 6, 2025
@s1na s1na changed the title ethapi: add timestamp to logs in eth_simulate internal/ethapi: add timestamp to logs in eth_simulate Oct 6, 2025
@s1na s1na merged commit 477ee58 into ethereum:master Oct 6, 2025
6 of 7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@s1na s1na s1na approved these changes

@fjl fjl Awaiting requested review from fjl fjl is a code owner

@lightclient lightclient Awaiting requested review from lightclient lightclient is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
1.16.5
Development

Successfully merging this pull request may close these issues.
2 participants
@deffrian @s1na